Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: set up gh actions #1

Merged
merged 12 commits into from
Jun 28, 2024
Merged

ci: set up gh actions #1

merged 12 commits into from
Jun 28, 2024

Conversation

rafaelcr
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Jun 27, 2024

The author of this PR, rafaelcr, is not an activated member of this organization on Codecov.
Please activate this user on Codecov to display this PR comment.
Coverage data is still being uploaded to Codecov.io for purposes of overall coverage calculations.
Please don't hesitate to email us at [email protected] with any questions.

@rafaelcr rafaelcr requested a review from CharlieC3 June 27, 2024 22:17
Copy link
Member

@CharlieC3 CharlieC3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After an initial pass this seems to be in good shape! The only thing missing is the .releaserc file which configures the semantic-release plugin. And it might take a couple attempts to get it to version the runehook cargo.toml and runes-api package.json correctly.

Here's a couple references we can use to write this:
https://github.com/hirosystems/stacks-blockchain-api/blob/develop/.releaserc
https://github.com/hirosystems/gh-actions-example/blob/main/package.json

And I'm interested in trying this plugin to version the cargo.toml: https://github.com/semantic-release-cargo/semantic-release-cargo

Let me know if you'd like help on this, I'm happy to take a stab at it.

.releaserc Show resolved Hide resolved
Copy link
Member

@CharlieC3 CharlieC3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🤞

@rafaelcr rafaelcr merged commit efdc8cf into main Jun 28, 2024
8 checks passed
@rafaelcr rafaelcr deleted the feat/ci branch June 28, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants