Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: read stacks-core http event POST payloads for ignored events #673

Merged
merged 2 commits into from
Oct 31, 2024

Conversation

zone117x
Copy link
Member

@zone117x zone117x commented Oct 30, 2024

Workaround for bug in stacks-core event emitter http code. Regression in stacks-core where http requests must now have their POST body read before closing the connection.

chainhook-1    | {"msg":"POST /drop_mempool_tx","level":"DEBUG","ts":"2024-10-30T10:41:34.030361652Z"}
stacks-node-1  | WARN [1730284894.031170] [testnet/stacks-node/src/event_dispatcher.rs:496] [relayer-http://0.0.0.0:20443/] Event dispatcher: connection or request failed to chainhook:20455 - Custom { kind: Other, error: "Failed to send 8192 bytes: \"Failed to send socket data\"" }, backoff: 158.191s, attempts: 10

Chainhook ignored some events by returning a 200 http response and closing the connection after reading the http request headers, and ignoring the request body.

@zone117x zone117x requested a review from rafaelcr October 30, 2024 11:41
@zone117x zone117x merged commit a01470e into stacks-signers Oct 31, 2024
9 checks passed
@zone117x zone117x deleted the fix/ignored-events-post-body branch October 31, 2024 14:24
@zone117x zone117x had a problem deploying to Development-mainnet October 31, 2024 14:36 — with GitHub Actions Failure
@zone117x zone117x had a problem deploying to Development-testnet October 31, 2024 14:36 — with GitHub Actions Failure
github-actions bot pushed a commit that referenced this pull request Oct 31, 2024
## [1.9.0-stacks-signers.6](v1.9.0-stacks-signers.5...v1.9.0-stacks-signers.6) (2024-10-31)

### Bug Fixes

* read stacks-core http event POST payloads for ignored events ([#673](#673)) ([a01470e](a01470e))
Copy link

🎉 This PR is included in version 1.9.0-stacks-signers.6 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants