Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return 500 status code to Stacks node when event ingestion fails #648

Merged
merged 13 commits into from
Oct 8, 2024

Conversation

rafaelcr
Copy link
Collaborator

@rafaelcr rafaelcr commented Oct 3, 2024

This PR makes sure we return a 500 status code error to the Stacks node when chainhook failed to ingest an event correctly, so it can retry indefinitely until it succeeds.

This prevents block gaps from occurring in the chainhook index.

Fixes #646

@rafaelcr rafaelcr temporarily deployed to Development-testnet October 3, 2024 17:42 — with GitHub Actions Inactive
@rafaelcr rafaelcr changed the title fix: respond with 500s when errors happen fix: reject stacks blocks that come out of sync from the latest chain tip Oct 3, 2024
@rafaelcr rafaelcr temporarily deployed to Development-testnet October 3, 2024 23:46 — with GitHub Actions Inactive
@rafaelcr rafaelcr changed the title fix: reject stacks blocks that come out of sync from the latest chain tip fix: return 500 status code error to Stacks node when error occurs Oct 4, 2024
@rafaelcr rafaelcr requested a review from csgui October 4, 2024 16:13
@rafaelcr rafaelcr marked this pull request as ready for review October 4, 2024 16:13
@rafaelcr rafaelcr requested a review from tippenein October 4, 2024 16:19
@rafaelcr rafaelcr changed the title fix: return 500 status code error to Stacks node when error occurs fix: return 500 status code to Stacks node when event ingestion fails Oct 4, 2024
Copy link
Contributor

@csgui csgui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check my comments. Maybe we can try to improve the implementation a bit. Thanks.

@rafaelcr rafaelcr requested a review from csgui October 8, 2024 14:39
Copy link
Contributor

@csgui csgui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM!

@rafaelcr rafaelcr had a problem deploying to Development-mainnet October 8, 2024 16:59 — with GitHub Actions Failure
@rafaelcr rafaelcr had a problem deploying to Development-testnet October 8, 2024 16:59 — with GitHub Actions Failure
@rafaelcr rafaelcr merged commit 63c753c into develop Oct 8, 2024
10 of 12 checks passed
@rafaelcr rafaelcr deleted the fix/stacks-responses branch October 8, 2024 17:06
github-actions bot pushed a commit that referenced this pull request Oct 25, 2024
## [1.9.0-stacks-signers.1](v1.8.0...v1.9.0-stacks-signers.1) (2024-10-25)

### Features

* add various new nakamoto block fields to `/new_block` ingestion and `StacksPayload` ([#659](#659)) ([f48cda5](f48cda5))
* include recovered signer pubkeys in new block payload ([#662](#662)) ([b5ad4ba](b5ad4ba))
* include signer messages in Stacks predicate payloads ([#656](#656)) ([aee14bc](aee14bc))
* parse `/stackerdb_chunks` Stacks node event ([#653](#653)) ([e44d84a](e44d84a))
* store signer messages in local sqlite database ([#664](#664)) ([d12acd9](d12acd9))
* support tenure-height in block messages ([#661](#661)) ([99e5a61](99e5a61))
* **ts-client:** add persisted predicates and periodic health check ([#658](#658)) ([535226a](535226a))
* **ts-client:** add signer messages to stacks payloads ([#657](#657)) ([ff66bb2](ff66bb2))

### Bug Fixes

* add a configurable max timeout for outgoing predicate payload requests ([#642](#642)) ([6c1dfa9](6c1dfa9)), closes [#643](#643)
* increase stacks event server body size limit to 500MB ([#660](#660)) ([21234c9](21234c9))
* return 500 status code to Stacks node when event ingestion fails ([#648](#648)) ([63c753c](63c753c)), closes [#646](#646)
* signer pubkey calculation ([#665](#665)) ([cc93873](cc93873))
* update SignerMessage deserializing ([#663](#663)) ([71364c1](71364c1))
* validate ts client predicates before registering ([#639](#639)) ([2d08f72](2d08f72))
Copy link

🎉 This PR is included in version 1.9.0-stacks-signers.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

return 500 status codes properly when a Stacks block could not be ingested
2 participants