fix: allow aborting a predicate scan #601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MicaiahReid
temporarily deployed
to
Development-mainnet
GitHub Actions
Inactive
MicaiahReid
temporarily deployed
to
Development-testnet
GitHub Actions
Inactive
MicaiahReid
temporarily deployed
to
Staging-mainnet
GitHub Actions
Inactive
MicaiahReid
temporarily deployed
to
Staging-testnet
GitHub Actions
Inactive
MicaiahReid
had a problem deploying
to
Development-mainnet
GitHub Actions
Error
MicaiahReid
had a problem deploying
to
Development-testnet
GitHub Actions
Error
rafaelcr
approved these changes
Jun 18, 2024
MicaiahReid
force-pushed
the
cancel-scans
branch
from
c33571f to
667c98b
Compare
MicaiahReid
force-pushed
the
cancel-scans
branch
from
667c98b to
510b40a
Compare
MicaiahReid
temporarily deployed
to
Development-mainnet
GitHub Actions
Inactive
MicaiahReid
temporarily deployed
to
Development-testnet
GitHub Actions
Inactive
MicaiahReid
temporarily deployed
to
Staging-mainnet
GitHub Actions
Inactive
MicaiahReid
temporarily deployed
to
Staging-testnet
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when Chainhook was run as a service and the runloop to scan stacks/bitcoin predicates was set, we had no way to abort that scan. If a predicate was set to scan 1m blocks, but the user discovered the predicate was wrong and needed to delete, the user could delete the predicate from the store, but the scan thread had already started and would run until completion.
This PR adds an abort signal to an ongoing scan so that when a predicate is deregistered, the scan is canceled.