Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: print to console for unknown cli commands #595

Merged
merged 2 commits into from
May 30, 2024
Merged

Conversation

MicaiahReid
Copy link
Contributor

Previously, these were output as CRIT errors, but they should just be printed to the console.

Copy link

codecov bot commented May 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 62.60%. Comparing base (ddb1e41) to head (70f48c7).
Report is 2 commits behind head on main.

Current head 70f48c7 differs from pull request most recent head b31a16e

Please upload reports for the commit b31a16e to get more accurate results.

Files Patch % Lines
components/chainhook-cli/src/cli/mod.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #595   +/-   ##
=======================================
  Coverage   62.60%   62.60%           
=======================================
  Files          31       31           
  Lines        6004     6004           
=======================================
  Hits         3759     3759           
  Misses       2245     2245           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

components/chainhook-cli/src/cli/mod.rs Outdated Show resolved Hide resolved
@MicaiahReid MicaiahReid requested a review from csgui May 29, 2024 19:26
Copy link
Contributor

@csgui csgui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MicaiahReid MicaiahReid merged commit f523ba0 into main May 30, 2024
10 of 12 checks passed
@MicaiahReid MicaiahReid deleted the fix/clap-logging branch May 30, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants