Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use stacks_node_rpc_url from config #579

Merged
merged 4 commits into from
May 30, 2024

Conversation

MicaiahReid
Copy link
Contributor

No description provided.

@MicaiahReid MicaiahReid requested a review from lgalabru May 8, 2024 14:45
Copy link

codecov bot commented May 8, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 62.15%. Comparing base (ddb1e41) to head (8809637).
Report is 3 commits behind head on main.

Current head 8809637 differs from pull request most recent head 6ecb79a

Please upload reports for the commit 6ecb79a to get more accurate results.

Files Patch % Lines
components/chainhook-types-rs/src/rosetta.rs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #579      +/-   ##
==========================================
- Coverage   62.60%   62.15%   -0.46%     
==========================================
  Files          31       31              
  Lines        6004     6088      +84     
==========================================
+ Hits         3759     3784      +25     
- Misses       2245     2304      +59     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MicaiahReid MicaiahReid requested a review from csgui May 29, 2024 14:11
@MicaiahReid MicaiahReid force-pushed the fix/configurable-stacks-rpc branch from 8809637 to 8de6396 Compare May 29, 2024 15:31
@MicaiahReid MicaiahReid requested a review from csgui May 30, 2024 14:29
@MicaiahReid MicaiahReid changed the base branch from develop to main May 30, 2024 14:30
@MicaiahReid MicaiahReid force-pushed the fix/configurable-stacks-rpc branch from c4a089c to 3b0f1cc Compare May 30, 2024 14:35
@MicaiahReid
Copy link
Contributor Author

@csgui Thanks for the review! I realized the original was targeting the wrong branch (I recently switched to using just main rather than main/develop), so I had to do a rebase. I've addressed your comments though 👍

@MicaiahReid MicaiahReid had a problem deploying to Development-mainnet May 30, 2024 15:13 — with GitHub Actions Failure
@MicaiahReid MicaiahReid had a problem deploying to Development-testnet May 30, 2024 15:13 — with GitHub Actions Failure
Copy link
Contributor

@csgui csgui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM! Thanks for the changes, Micaiah.

@MicaiahReid MicaiahReid merged commit 75a7278 into main May 30, 2024
10 of 12 checks passed
@MicaiahReid MicaiahReid deleted the fix/configurable-stacks-rpc branch May 30, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants