Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add nonce to serialized stacks tx #430

Merged
merged 2 commits into from
Oct 4, 2023
Merged

fix: add nonce to serialized stacks tx #430

merged 2 commits into from
Oct 4, 2023

Conversation

MicaiahReid
Copy link
Contributor

@MicaiahReid MicaiahReid commented Oct 4, 2023 •
edited
Loading

Fixes #422

@MicaiahReid MicaiahReid requested a review from lgalabru October 4, 2023 16:52
sabbyanandan
sabbyanandan suggested changes Oct 4, 2023
View reviewed changes
Copy link

@sabbyanandan sabbyanandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious about the other ask from the Zero, which I linked in my comment.

components/chainhook-sdk/src/chainhooks/stacks/mod.rs Show resolved Hide resolved
lgalabru
lgalabru approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@lgalabru lgalabru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MicaiahReid!

sabbyanandan
sabbyanandan approved these changes Oct 4, 2023
View reviewed changes
Copy link

@sabbyanandan sabbyanandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heck yeah; thank you!

@MicaiahReid MicaiahReid merged commit 95b2dd7 into develop Oct 4, 2023
1 check passed
@MicaiahReid MicaiahReid deleted the fix-nonce branch October 4, 2023 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sabbyanandan sabbyanandan sabbyanandan approved these changes

@lgalabru lgalabru lgalabru approved these changes

Assignees
No one assigned
Labels
None yet
Projects
DevTools
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Include "nonce" as part of the event stream response
3 participants
@MicaiahReid @lgalabru @sabbyanandan