Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update CD process #421

Merged
merged 13 commits into from
Oct 5, 2023
Merged

ci: update CD process #421

merged 13 commits into from
Oct 5, 2023

Conversation

deantchi
Copy link
Contributor

changes to the CI workflow.
adding auto deployments using docker container digest to the k8s repo.
dev and stg will auto approve, while prod will require manual approval

@deantchi deantchi temporarily deployed to Production September 29, 2023 16:54 — with GitHub Actions Inactive
@deantchi deantchi temporarily deployed to Staging September 29, 2023 16:54 — with GitHub Actions Inactive
@deantchi deantchi temporarily deployed to Development September 29, 2023 16:54 — with GitHub Actions Inactive
Copy link
Member

@CharlieC3 CharlieC3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start! Just a few tweaks.

.github/workflows/ci.yaml Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Show resolved Hide resolved
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
@CharlieC3
Copy link
Member

@deantchi you'll also need to update the chainhook manifests to apply the environment-level patch using digest instead of newTag.
See the Explorer or stacks-devnet-api manifests for a reference if needed.

@deantchi deantchi temporarily deployed to Development September 29, 2023 20:36 — with GitHub Actions Inactive
@deantchi deantchi temporarily deployed to Development September 29, 2023 20:37 — with GitHub Actions Inactive
@deantchi deantchi requested a review from CharlieC3 September 29, 2023 20:42
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Show resolved Hide resolved
@deantchi deantchi temporarily deployed to Development-mainnet October 2, 2023 15:23 — with GitHub Actions Inactive
@deantchi deantchi temporarily deployed to Development-testnet October 2, 2023 15:23 — with GitHub Actions Inactive
@lgalabru
Copy link
Contributor

lgalabru commented Oct 2, 2023

🤤
Thank you for this new flow @deantchi @CharlieC3!

@deantchi deantchi temporarily deployed to Staging-mainnet October 2, 2023 17:11 — with GitHub Actions Inactive
@deantchi deantchi temporarily deployed to Staging-testnet October 2, 2023 17:11 — with GitHub Actions Inactive
@deantchi deantchi changed the title Devops 1305 ci: update CD process Oct 2, 2023
@CharlieC3 CharlieC3 temporarily deployed to Development-mainnet October 4, 2023 21:08 — with GitHub Actions Inactive
@CharlieC3 CharlieC3 temporarily deployed to Development-testnet October 4, 2023 21:08 — with GitHub Actions Inactive
@CharlieC3 CharlieC3 temporarily deployed to Staging-mainnet October 4, 2023 21:14 — with GitHub Actions Inactive
@CharlieC3 CharlieC3 temporarily deployed to Staging-testnet October 4, 2023 21:14 — with GitHub Actions Inactive
@CharlieC3 CharlieC3 temporarily deployed to Development-testnet October 4, 2023 23:14 — with GitHub Actions Inactive
@CharlieC3 CharlieC3 temporarily deployed to Development-mainnet October 4, 2023 23:14 — with GitHub Actions Inactive
@CharlieC3 CharlieC3 temporarily deployed to Staging-testnet October 5, 2023 00:35 — with GitHub Actions Inactive
@CharlieC3 CharlieC3 temporarily deployed to Staging-mainnet October 5, 2023 00:36 — with GitHub Actions Inactive
Copy link
Member

@CharlieC3 CharlieC3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a few changes to help with CI performance, specifically added caching for cargo tests and docker image build. In the best case scenario, this should reduce CI pipeline times from ~35 minutes to ~6 minutes.
In addition to that, I fixed some dependency issues between jobs, ensured the new tag is being checked out once a new release is published, removed the blockstack Docker hub org from being used, and some other minor fixes.

I'd like either @MicaiahReid or @deantchi to check this PR again and re-approve if possible.

Copy link
Contributor

@MicaiahReid MicaiahReid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🚀 🚀

@MicaiahReid MicaiahReid merged commit da500d7 into develop Oct 5, 2023
3 of 5 checks passed
@MicaiahReid MicaiahReid deleted the devops-1305 branch October 5, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants