Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update predicate status format for easier parsing #420

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

MicaiahReid
Copy link
Contributor

@MicaiahReid MicaiahReid commented Sep 22, 2023

Description

Previously, a serialized PredicateStatus would have the format:

{ "scanning": { "last_evaluated_block": ... }

where the predicate status type is the key that points to the data. This PR changes this format to be:

{
  "type": "scanning",
  "info": { "last_evaluated_block": ... }
}

Checklist

  • All tests pass

Copy link
Contributor

@lgalabru lgalabru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, thanks!

Copy link

@BLuEScioN BLuEScioN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this. This helps

@MicaiahReid MicaiahReid merged commit 04249e3 into develop Sep 25, 2023
1 check passed
@MicaiahReid MicaiahReid deleted the update-status-format branch September 25, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants