fix: op_return predicate evaluation #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Still a draft, since I'm not so sure if the tests on the PR are the right way to go. |
qustavo
force-pushed
the
fix/opreturn_evaluation
branch
3 times, most recently
from
18484fd to
247c2d7
Compare
qustavo
force-pushed
the
fix/opreturn_evaluation
branch
from
247c2d7 to
51eb307
Compare
|
@lgalabru can you have a look at why CI is failing? |
|
CI is failing because it's being triggered from your fork, that does not have knowledges of the secrets required to push a build to Dockerhub. Safe to ignore! |
|
For some reason I can't set reviewers, probably a permission issue. |
MicaiahReid
approved these changes
Sep 26, 2023
|
@lgalabru @MicaiahReid is there anything else left to do for this PR to get merged? |
|
Done! thank you @qustavo 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Handles OP_RETURN predicates correctly.
Breaking change?
Potentially yes, but unlikely.
Currently there is a OP_RETURN handler, that matches the
output.script_pubkeyagainst the expression set in the predicate, although this implementation does not confirm with the documentation, someone might be relying on itChecklist
fixes #385 #388