Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove input from error messages #23

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

He1DAr
Copy link
Contributor

@He1DAr He1DAr commented Jul 3, 2024

@He1DAr He1DAr requested review from rafaelcr and zone117x July 3, 2024 16:27
src/helpers/values.ts Outdated Show resolved Hide resolved
@He1DAr He1DAr force-pushed the fix/remove-input-from-error-messages branch 2 times, most recently from ffc9be2 to 68e4bd4 Compare July 3, 2024 16:33
@He1DAr He1DAr requested a review from zone117x July 3, 2024 16:33
Copy link

@smcclellan smcclellan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we still want to log the hex value for ease of debugging?

@He1DAr
Copy link
Contributor Author

He1DAr commented Jul 3, 2024

Maybe we still want to log the hex value for ease of debugging?

I think library consumers can still debug the error as they have access to the input, so if a consumer is calling the library they could do something like:

const input = 'my_input'
try {
   bufferToHex(input)
} catch (error) {
   console.log(`failed with input ${input}} due to ${error.message}`)
}

This way the library would remain unopinionated. Open to suggestions.

Copy link
Member

@zone117x zone117x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @He1DAr !

@He1DAr He1DAr merged commit 0e9cb84 into develop Jul 5, 2024
4 checks passed
@He1DAr He1DAr deleted the fix/remove-input-from-error-messages branch July 5, 2024 13:50
He1DAr added a commit that referenced this pull request Jul 5, 2024
…essages

fix: remove input from error messages
@blockstack-devops
Copy link

🎉 This PR is included in version 1.6.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

remove hash from error message
4 participants