Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better singletons #172

Merged
merged 6 commits into from
Jan 8, 2025
Merged

Better singletons #172

merged 6 commits into from
Jan 8, 2025

Conversation

inxilpro
Copy link
Contributor

Originally, we implemented AppliesToSingletonState as the way of marking a state as a singleton. This is an artifact of how states were originally defined in early versions of Verbs. A much more straightforward approach is to just have a SingletonState class. This allows us to avoid passing singleton: true all over the place, and is just more obvious and simple.

@inxilpro
Copy link
Contributor Author

Just reviewed with Daniel. This will be a breaking change so we have to plan the release, but generally it's good.

@DanielCoulbourne DanielCoulbourne added the blocks 1.0 We can't release v1.0 until this is merged label Jan 6, 2025
@inxilpro inxilpro merged commit 64fbd09 into main Jan 8, 2025
42 checks passed
@inxilpro inxilpro deleted the better-singletons branch January 8, 2025 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocks 1.0 We can't release v1.0 until this is merged breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants