Updates for compatibility with newer numpy / PyPI#113
Updates for compatibility with newer numpy / PyPI#113gesinecauer merged 17 commits intohiclib:masterfrom
Conversation
|
@NelleV the installation error I'd been having was due to PASTIS being installed before numpy, and I resolved it by letting conda install numpy instead of pip. Was there a reason you had the environment.yml written such that pip would install most of the dependencies? And is it okay to make this change re numpy installation? |
|
@NelleV looks like the tests are currently failing because it's using the pip-installed version of PASTIS instead of the code from this pull request. The errors are precisely what this pull request was created to address... How should I best resolve this? |
|
Removing PASTIS from the pip-installed packages in environment.yml resolved the above issue, tests are now run using the pull request code. Currently, the only failing test is I'm going to change this line to |
The following cause errors with the current versions of numpy / PyPI:
np.floatno longer exists, must be replace withfloatornp.float64np.boolno longer exists, must be replace withboolornp.bool_This pull request resolves these issues