Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

Revert "Limit the Make concurrency to 8 threads" #273

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Atry
Copy link
Contributor

@Atry Atry commented Jan 29, 2022

Reverts #260

Since we can allocate more memory and less CPU for better CPU utilization in #272

Copy link
Contributor

@fredemmott fredemmott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is most likely going to make the OOM problem worse; we need to solve that first, then we can look at improving performance.

Build reliability is more important than build time.

@Atry Atry marked this pull request as draft March 30, 2022 20:14
@facebook-github-bot
Copy link
Contributor

Hi @Atry!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants