Banish hh ignore error from codegen #544
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codegen changes in the next commit.
These aren't affected by the codegen changes.
These are particularly likely to cause non-local bugs (in general). By removing the `final` modifier, and sealing it empty, we can remove this directive.
This functionality can be implemented with a well-typed Hack API now, yippee!
lexidor
commented
Aug 16, 2023
lexidor
force-pushed
the
banish-hh-ignore-error-from-codegen
branch
from
a5901d4
to
680174a
Compare
|
CI doesn't run here anymore, so you'll have to look at the CI of my clone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
HH_IGNORE_ERRORdirectives in codegen.HH_IGNORE_ERRORdirectives in hand rolled nodes.HH_IGNORE_ERROR->HH\FIXME\UNSAFE_CAST<Ta, Tb>(...)migrations.HH_IGNORE_ERRORfrom declarations.