HH-239958 small fixes #561
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heruv1m
reviewed
Nov 29, 2024
| <dependency> | ||
| <groupId>org.openjdk.jmh</groupId> | ||
| <artifactId>jmh-generator-annprocess</artifactId> | ||
| <version>1.23</version> | ||
| <version>1.37</version> |
There was a problem hiding this comment.
всей этой мелочи нет в буте?
| @@ -168,16 +92,8 @@ | |||
| </exclusion> | |||
| </exclusions> | |||
| </dependency> | |||
| <dependency> | |||
| <groupId>com.fasterxml.jackson.module</groupId> | |||
There was a problem hiding this comment.
а ты как искал кого убрать?
| @SpringBootTest( | ||
| classes = {JpaTestConfig.class, NabJClientConfig.class, JClientTransactionTest.TestConfig.class} | ||
| ) | ||
| @SpringBootTest(classes = {JpaTestConfig.class, NabJClientConfig.class}, webEnvironment = SpringBootTest.WebEnvironment.NONE) |
There was a problem hiding this comment.
это типа оптимизации или зачем? .WebEnvironment.NONE)
| @Configuration | ||
| @EnableAutoConfiguration | ||
| @Import({NabTestConfig.class}) | ||
| public class NabWebTestConfig { |
There was a problem hiding this comment.
а ты вроде что то делал до этого похожее, чтобы подтягивался автоконфигов для тестов?
| @@ -42,7 +42,7 @@ | |||
| import ru.hh.nab.testbase.NabTestConfig; | |||
| import ru.hh.nab.testbase.web.WebTestBase; | |||
|
|
|||
| @SpringBootTest(webEnvironment = SpringBootTest.WebEnvironment.RANDOM_PORT) | |||
| @SpringBootTest(classes = TelemetryListenerTest.TestConfiguration.class, webEnvironment = SpringBootTest.WebEnvironment.RANDOM_PORT) | |||
There was a problem hiding this comment.
а почему это ранььше работало?
|
|
||
| @SpringBootTest(webEnvironment = SpringBootTest.WebEnvironment.RANDOM_PORT) | ||
| @SpringBootTest( |
There was a problem hiding this comment.
я правильно понимаю что ты тут просто красоту наводишь, и оно в принципе работало и в старом виде?
| @@ -0,0 +1,5 @@ | |||
| _ _ _ _ _ _ | |||
There was a problem hiding this comment.
а мы договорились сделать?
Я пропустил наверное. Мне казалось наоброт договорились убрать баннер совсем
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.