Fix error interceptors not being called for network failures #2656
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error interceptors in the custom client were not being triggered when network-level failures occurred (CORS errors, DNS failures, connection timeouts, etc.). This meant that developers' error handling and logging code was completely bypassed for some of the most common request failure scenarios.
Problem demonstrated:
Root cause:
The
fetch()
call was not wrapped in a try-catch block, so network exceptions bypassed the error interceptor logic entirely. Only HTTP response errors (4xx, 5xx status codes) were being handled.Solution:
ErrInterceptor
type signature to acceptresponse: Res | undefined
since network errors don't have a response objectundefined
as the response parameterAfter fix:
This makes error interceptors a reliable tool for handling all types of request failures, improving debugging capabilities and making the client behavior more predictable.
Fixes #1994.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
messedupbaseurl
node /tmp/demo-fix-1994.js
(dns block)nonexistent-domain-12345.com
node /tmp/test-error-interceptors.js
(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.