Replace DownloadSourceStep with the package manager #11
+967
−972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents an error when trying to pull a shared machdxcompiler through the package manager `panic: artifact name 'machdxcompiler' is ambiguous`
|
@Beyley are you still able to repro ziglang/zig#20313 with Zig master? I just tried switching to Zig master on my repro project and it seems to work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works correctly on my Linux host, and I can cross compile to all supported platforms, but this fails on a macOS host due to ziglang/zig#20313, and we can't mark some dependencies as lazy due to ziglang/zig#21771.
The latter has actually been fixed, but the fix isn't available until Mach Zig is updated. I haven't been able to find a direct workaround for the macOS issue yet, so I'm going to mark this as draft for now.