Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for generic types expressed by selector expressions #84

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

breml
Copy link
Contributor

@breml breml commented Mar 7, 2024

Add support for generic interfaces with selector expressions for the type, e.g.:

package foo

import (
	"bar"
)

type Fooer[T bar.Bar] interface {
	Foo() T
}

or

package foo

import (
	"bar"
)

type Fooer[T Bar] interface {
	Foo() T
}

where the destination file could be in the same or in a different package.

@breml breml marked this pull request as draft March 7, 2024 10:30
@breml breml force-pushed the selector-expressions branch 2 times, most recently from 36daf00 to 3bdb926 Compare March 7, 2024 11:50
@breml breml marked this pull request as ready for review March 7, 2024 11:50
@breml breml force-pushed the selector-expressions branch from 3bdb926 to abec8df Compare March 7, 2024 12:17
@breml
Copy link
Contributor Author

breml commented Mar 26, 2024

Hi @hexdigest
I hope you don't mind me following up on this pull request. I contributed to gowrap in the past and I remember it being a swift experience. Based on the open issues and PR in this repo (as well as your recent Github contribution history) I wonder about the current state of maintenance of gowrap. Can you share you thoughts on this?

@hexdigest hexdigest merged commit 55c8e85 into hexdigest:master Apr 3, 2024
1 check passed
@hexdigest
Copy link
Owner

Hi @breml,

Excuse me for the delay, and than you for the contribution!
This fix should be in v1.3.5

@breml
Copy link
Contributor Author

breml commented Apr 4, 2024

@hexdigest thank you for merging the PR, I am happy to help with this contribution.
No worry about the delay. Maintaining some open source myself as well, I do understand the tension this brings.
Thank you for maintaining gowrap ❤️ .

@breml breml deleted the selector-expressions branch April 4, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants