Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: make base describe command generic #972

Merged
merged 1 commit into from
Jan 31, 2025
Merged

Conversation

phm07
Copy link
Contributor

@phm07 phm07 commented Jan 31, 2025

More type safety <3

@phm07 phm07 self-assigned this Jan 31, 2025
@phm07 phm07 requested a review from a team as a code owner January 31, 2025 15:59
Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.12%. Comparing base (0ccd41c) to head (591d1d8).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #972      +/-   ##
==========================================
+ Coverage   70.01%   70.12%   +0.11%     
==========================================
  Files         245      245              
  Lines       10715    10756      +41     
==========================================
+ Hits         7502     7543      +41     
  Misses       2537     2537              
  Partials      676      676              
Flag Coverage Δ
e2e 46.82% <58.82%> (+0.04%) ⬆️
unit 63.59% <100.00%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@apricote apricote force-pushed the describe-cmd-generic branch from f114b2e to 591d1d8 Compare January 31, 2025 16:04
@apricote apricote merged commit d447b0c into main Jan 31, 2025
6 checks passed
@apricote apricote deleted the describe-cmd-generic branch January 31, 2025 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants