Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: split up label command into separate Fetch/GetLabels/GetIDOrName #967

Merged
merged 2 commits into from
Jan 31, 2025

Conversation

phm07
Copy link
Contributor

@phm07 phm07 commented Jan 23, 2025

This change is intended for an upcoming resource that has labels but doesn't have numeric IDs.

@phm07 phm07 self-assigned this Jan 23, 2025
@phm07 phm07 requested a review from a team as a code owner January 23, 2025 16:56
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 85.33333% with 22 lines in your changes missing coverage. Please review.

Project coverage is 70.20%. Comparing base (0ccd41c) to head (09c9f5d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/cmd/base/labels.go 70.58% 3 Missing and 2 partials ⚠️
internal/cmd/image/labels.go 76.92% 3 Missing ⚠️
internal/cmd/loadbalancer/labels.go 83.33% 2 Missing ⚠️
internal/cmd/primaryip/labels.go 83.33% 2 Missing ⚠️
internal/cmd/server/labels.go 83.33% 2 Missing ⚠️
internal/cmd/volume/labels.go 83.33% 2 Missing ⚠️
internal/cmd/certificate/labels.go 91.66% 1 Missing ⚠️
internal/cmd/firewall/labels.go 91.66% 1 Missing ⚠️
internal/cmd/floatingip/labels.go 91.66% 1 Missing ⚠️
internal/cmd/network/labels.go 91.66% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #967      +/-   ##
==========================================
+ Coverage   70.01%   70.20%   +0.19%     
==========================================
  Files         245      245              
  Lines       10715    10785      +70     
==========================================
+ Hits         7502     7572      +70     
  Misses       2537     2537              
  Partials      676      676              
Flag Coverage Δ
e2e 46.85% <52.00%> (+0.06%) ⬆️
unit 63.69% <81.33%> (+0.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@apricote apricote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where do you intend to use this? / What is the benefit of this refactor?

internal/cmd/base/labels.go Outdated Show resolved Hide resolved
@phm07 phm07 merged commit d846f49 into main Jan 31, 2025
6 checks passed
@phm07 phm07 deleted the refactor-label branch January 31, 2025 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants