Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(e2e): add e2e tests for certificate resource #945

Merged
merged 5 commits into from
Jan 3, 2025
Merged

Conversation

phm07
Copy link
Contributor

@phm07 phm07 commented Jan 2, 2025

No description provided.

@phm07 phm07 added the test label Jan 2, 2025
@phm07 phm07 self-assigned this Jan 2, 2025
@phm07 phm07 requested a review from a team as a code owner January 2, 2025 13:26
Copy link

codecov bot commented Jan 2, 2025

Codecov Report

Attention: Patch coverage is 58.62069% with 24 lines in your changes missing coverage. Please review.

Project coverage is 69.76%. Comparing base (2798902) to head (8e080df).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
test/e2e/certificate_util.go 57.89% 16 Missing and 8 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #945      +/-   ##
==========================================
+ Coverage   69.53%   69.76%   +0.23%     
==========================================
  Files         244      245       +1     
  Lines       10654    10711      +57     
==========================================
+ Hits         7408     7473      +65     
+ Misses       2574     2562      -12     
- Partials      672      676       +4     
Flag Coverage Δ
e2e 45.58% <58.62%> (+1.71%) ⬆️
unit 63.48% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@phm07 phm07 force-pushed the test-e2e-certificates branch from 031ffd0 to c869349 Compare January 2, 2025 13:29
test/e2e/certificate_test.go Outdated Show resolved Hide resolved
test/e2e/certificate_test.go Show resolved Hide resolved
@phm07 phm07 force-pushed the test-e2e-certificates branch from 7592a74 to e82f00a Compare January 3, 2025 11:17
@phm07 phm07 changed the base branch from main to certificate-create-label January 3, 2025 11:17
Base automatically changed from certificate-create-label to main January 3, 2025 11:21
@jooola jooola force-pushed the test-e2e-certificates branch from e82f00a to 8e080df Compare January 3, 2025 11:45
@phm07 phm07 merged commit ee2aed7 into main Jan 3, 2025
6 checks passed
@phm07 phm07 deleted the test-e2e-certificates branch January 3, 2025 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants