Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed application dir used for COREPACK_HOME in CI env #1320

Merged
merged 4 commits into from
Sep 20, 2024

Conversation

colincasey
Copy link
Contributor

@colincasey colincasey commented Sep 10, 2024

The COREPACK_HOME directory was mistakenly set to use BUILD_DIR instead of HOME as the application root directory in the CI test environment causing failures when invoking pnpm or Yarn tests if those tools were installed via corepack.


Workaround

Warning

The following is meant to be used as a temporary change to unblock anyone affected by this bug. Once this change is released, please remember to remove the workaround.

  • Specify or replace the heroku/nodejs buildpack in app.json with the url of this branch:
{
  "environments": {
    "test": {
      "buildpacks": [
        {
          "url": "https://github.com/heroku/heroku-buildpack-nodejs#corepack-ci-fix"
        }
      ]
    }
  }
}

@colincasey colincasey self-assigned this Sep 10, 2024
@colincasey colincasey requested a review from a team as a code owner September 10, 2024 13:41
@colincasey colincasey changed the title Fixed root dir used for COREPACK_HOME in CI env Fixed application dir used for COREPACK_HOME in CI env Sep 10, 2024
@colincasey colincasey merged commit 90d91c8 into main Sep 20, 2024
11 checks passed
@colincasey colincasey deleted the corepack-ci-fix branch September 20, 2024 16:08
@heroku-linguist heroku-linguist bot mentioned this pull request Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants