Skip to content

Commit

Permalink
Update default Node.js version to 22.x (#1341)
Browse files Browse the repository at this point in the history
* Update default Node.js version to 22.x

* Add PR link to changelog entry
  • Loading branch information
joshwlewis authored Oct 31, 2024
1 parent 3d570e2 commit 6741959
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 4 deletions.
3 changes: 2 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

## [Unreleased]

- Updated default Node.js version to 22.x ([#1341](https://github.com/heroku/heroku-buildpack-nodejs/pull/1341))
- Added Node.js version 22.11.0.

## [v268] - 2024-10-25
Expand All @@ -23,7 +24,7 @@

- Added Node.js version 22.9.0.
- Added Yarn version 4.5.0.
- Fixed application directory used for `COREPACK_HOME` in CI env ([#1320](https://github.com/heroku/heroku-buildpack-nodejs/pull/1320))
- Fixed application directory used for `COREPACK_HOME` in CI env ([#1320](https://github.com/heroku/heroku-buildpack-nodejs/pull/1320))
- Fail on conflicting package manager metadata in package.json. ([#1317](https://github.com/heroku/heroku-buildpack-nodejs/pull/1317))

## [v264] - 2024-09-05
Expand Down
4 changes: 2 additions & 2 deletions lib/binaries.sh
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ install_nodejs() {
local code resolve_result

if [[ -z "$version" ]]; then
version="20.x"
version="22.x"
fi

if [[ -n "$NODE_BINARY_URL" ]]; then
Expand All @@ -90,7 +90,7 @@ install_nodejs() {

echo "Downloading and installing node $number..."

if [[ "$number" == "22.5.0" ]]; then
if [[ "$number" == "22.5.0" ]]; then
warn_about_node_version_22_5_0
fi
fi
Expand Down
2 changes: 1 addition & 1 deletion test/run
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ testYarnRun() {
}

testNoVersion() {
local default_version="20"
local default_version="22"
compile "no-version"
assertCaptured "engines.node (package.json): unspecified"
assertCaptured "Resolving node version ${default_version}.x"
Expand Down

0 comments on commit 6741959

Please sign in to comment.