Set key for modules and nixosModules
#251
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm slightly concerned about overridden inputs not being represented in the key, but this may be the lesser evil of the two. |
roberth
approved these changes
Sep 13, 2024
roberth
requested changes
Sep 13, 2024
There was a problem hiding this comment.
Coming to think of it, since we have this logic in two places now, it should be factored out, and since we're enabling new behavior, we should test it.
Specifically, eval-tests.nix should check that deduplication works (e.g. with a list-typed option that merges by appending, as usual), and that disabledModules works.
I won't have time for it in the coming days, so feel free to give it a shot.
Co-authored-by: Robert Hensing <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes NixOS/nixpkgs#340361