make less likely to spend coinbase #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClaytonNorthey92
force-pushed
the
clayton/no-coinbase
branch
5 times, most recently
from
d0f7e69
to
0b970ab
Compare
ClaytonNorthey92
changed the title
ClaytonNorthey92
force-pushed
the
clayton/no-coinbase
branch
from
e73787f
to
d905dfa
Compare
ClaytonNorthey92
changed the title
ClaytonNorthey92
changed the title
ClaytonNorthey92
changed the title
ClaytonNorthey92
requested review from
jcvernaleo,
max-sanchez,
marcopeereboom and
joshuasing
ClaytonNorthey92
added
area: test
ClaytonNorthey92
force-pushed
the
clayton/no-coinbase
branch
3 times, most recently
from
fa49615
to
5ae49b6
Compare
|
closing for #12 |
|
actually, re-opening in case the other takes longer than expected |
* generate 5000 blocks to start network test, to make it less likely that we will choose a premature utxo * give time for l2 keystone to be mined fixes #2
ClaytonNorthey92
force-pushed
the
clayton/no-coinbase
branch
from
d6f8e83
to
f88485d
Compare
ClaytonNorthey92
changed the title
joshuasing
approved these changes
Feb 28, 2024
web3cryptoguy
pushed a commit
to web3cryptoguy/heminetwork
that referenced
this pull request
Nov 1, 2024
* generate 5000 blocks to start network test, to make it less likely that we will choose a premature utxo * give time for l2 keystone to be mined fixes hemilabs#2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
prior, upon investigating full network e2e tests, I was seeing the following:
bfg: bad-txns-premature-spend-of-coinbase, tried to spend coinbase at depth NChanges
fixes #2