Open
Conversation
Fix the wget line that downloads the actual charts. Previously this just passed a filename (not a url) to wget. That certainly doesn't do anything on /my/ version of wget. Signed-off-by: Andrew Bogott <Andrewbogott@gmail.com>
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the mirror-k8s-repos.sh script where wget was being called with just a filename instead of a complete URL. The fix ensures that charts can be properly downloaded by prepending the repository URL to the filename.
- Fixed wget command to use complete URL by prepending
$repo_url/to the filename - Corrected a logical error that would prevent the script from actually downloading files
| for tgz in $tgzs; do | ||
| if [ ! -f "${tgz##*/}" ]; then | ||
| wget $tgz | ||
| wget $repo_url/$tgz |
There was a problem hiding this comment.
The variable concatenation should be properly quoted to handle URLs or filenames with spaces or special characters. Consider using "$repo_url/$tgz" instead of $repo_url/$tgz.
Suggested change
| wget $repo_url/$tgz | |
| wget "$repo_url/$tgz" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the wget line that downloads the actual charts.
Previously this just passed a filename (not a url) to wget. That certainly doesn't do anything on /my/ version of wget.