sign_in_and_redirect implementation follows it's documentation #5587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`sign_in_and_redirect` documentation states that it only calls the `after_sign_in_path_for` method if no stored location was set. But the actual implementation always calls `after_sign_in_path_for`, which in it's default implementation (but not in all overriden versions) looks up the stored location first.
Lazarscorro
approved these changes
Sep 8, 2023
Lazarscorro
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sign_in_and_redirectdocumentation states that it only calls theafter_sign_in_path_formethod if no stored location was set. But the actual implementation always callsafter_sign_in_path_for, which in it's default implementation (but not in all overriden versions) looks up the stored location first.See mastodon/mastodon#24073 as an example of where this was the case.