[WIP] Issue #4209 - Add deliver_later option in send_devise_notification #4224

HexterCH · 2016-07-28T10:17:15Z

Add a class variable deliver_later_option and modify the method send_devise_notification

Now you can just add config.deliver_later_option = true in your config/initailizers/devise.rb, and devise mailer will use deliver_later to send every letter.

Hope to get some feedback. 😄

* Add private method devliery_method in models/authenticatable * Modify send_devise_notification by use delivery_method

deliver_later_option

lucasmazza · 2016-08-12T19:16:39Z

lib/devise/models/authenticatable.rb

@@ -187,8 +191,9 @@ def devise_mailer
      def send_devise_notification(notification, *args)
        message = devise_mailer.send(notification, self, *args)
        # Remove once we move to Rails 4.2+ only.
+
        if message.respond_to?(:deliver_now)


I think we can remove this if now, right? 😄

@HexterCH what do you think of this? I guess that's the only pending piece we have here.

@lucasmazza , but if remove this if, that meanings if user's environment don't support deliver_now or deliver_later will failed.

And really sorry about that I respond so lately. 😭

lucasmazza · 2016-08-12T19:17:23Z

@HexterCH thanks for tackling this, can you please add a small test case that asserts that the email is enqueued when the config is on?

lucasmazza · 2016-08-12T19:19:18Z

lib/devise.rb

@@ -286,6 +286,10 @@ module Test
  mattr_accessor :token_generator
  @@token_generator = nil

+  # Store devise notification delivery method, default is deliver now
+  mattr_accessor :deliver_later_option


We should add a new commenting section to the initializer template to document this for new apps.

HexterCH · 2016-08-17T11:31:16Z

Sure, I am working on it. 😄

…st case for deliver_later_option

HexterCH · 2016-09-08T04:45:32Z

I am stuck on this test, any relative test that I can reference ? 🆘

brunowego · 2017-01-31T19:21:55Z

@HexterCH exactly what I want! Waiting anxiously.

tegon · 2017-11-25T18:44:18Z

@HexterCH Thanks for your contribution, we appreciate it!
Sorry for the late response, but I think I can help you with that failing spec.

Your test failed in builds for rails 4.2 and mongoid, with the error ActiveJob::SerializationError: Unsupported argument type: User.
I did some debugging here, and the reason that it failed is: on rails 4.2, ActiveJob requires that any model passed to it should include the module GlobalID::Identification. Your build doesn't fail with active_record because the module is included by default.
Some references:

http://edgeguides.rubyonrails.org/active_job_basics.html#globalid
https://github.com/rails/rails/b lob/6375c9a3ae34cadd0d98e31ae1474fee26cf92ea/guides/source/4_2_release_notes.md#active-job
https://stackoverflow.com/questions/35554457/how-to-override-activejob-to-prevent-serialization-error

We can solve this issue by including the module in our User test class for mongoid:

# test/rails_app/app/mongoid/user.rb
require 'shared_user'

class User
  include Mongoid::Document
  include Shim
  include SharedUser
+ # Required for ActiveJob serialization. Reference: http://edgeguides.rubyonrails.org/active_job_basics.html#globalid
+ include GlobalID::Identification

tegon · 2018-01-12T02:54:51Z

I'm closing this since it has been here for a long time and probably will be too hard to rebase it.
If you find that this can still be relevant, feel free to open a new pull request with a similar implementation.

Thank you!

Re-opens [heartcombo#4224][] By default, all `Devise::Models::Authenticatable`-initiated Action Mailer deliveries are transmitted immediately (within the request-response cycle). Transmitting emails and interacting with any third-party services over SMTP or HTTP risk service outages and other types of network-related failures. This commit adds support for deferring delivery to be done from an Action Job background worker queue through the [deliver_later][] method. ```ruby # config/initializers/devise.rb Devise.mailer_delivery_method = :deliver_later ``` [heartcombo#4224]: heartcombo#4224 [deliver_now]: https://edgeapi.rubyonrails.org/classes/ActionMailer/MessageDelivery.html#method-i-deliver_now [deliver_later]: https://edgeapi.rubyonrails.org/classes/ActionMailer/MessageDelivery.html#method-i-deliver_later

seanpdoyle · 2023-08-08T18:22:21Z

@HexterCH @tegon I've re-opened this unit of work as part of #5610.

Re-opens [heartcombo#4224][] By default, all `Devise::Models::Authenticatable`-initiated Action Mailer deliveries are transmitted immediately (within the request-response cycle). Transmitting emails and interacting with any third-party services over SMTP or HTTP risk service outages and other types of network-related failures. This commit adds support for deferring delivery to be done from an Action Job background worker queue through the [deliver_later][] method. ```ruby # config/initializers/devise.rb Devise.mailer_delivery_method = :deliver_later ``` [heartcombo#4224]: heartcombo#4224 [deliver_now]: https://edgeapi.rubyonrails.org/classes/ActionMailer/MessageDelivery.html#method-i-deliver_now [deliver_later]: https://edgeapi.rubyonrails.org/classes/ActionMailer/MessageDelivery.html#method-i-deliver_later

* Add class value delivery_method

52f2431

* Add private method devliery_method in models/authenticatable * Modify send_devise_notification by use delivery_method

HexterCH changed the title ~~Issue #4209 - Add deliver_later option in send_devise_notification~~ [WIP] Issue #4209 - Add deliver_later option in send_devise_notification Jul 28, 2016

fix sned_devise_notification and change delivery_method to

3f82f7c

deliver_later_option

HexterCH changed the title ~~[WIP] Issue #4209 - Add deliver_later option in send_devise_notification~~ Issue #4209 - Add deliver_later option in send_devise_notification Jul 28, 2016

lucasmazza reviewed Aug 12, 2016
View reviewed changes

lucasmazza added the Needs review label Aug 12, 2016

lucasmazza reviewed Aug 12, 2016
View reviewed changes

HexterCH changed the title ~~Issue #4209 - Add deliver_later option in send_devise_notification~~ [WIP]Issue #4209 - Add deliver_later option in send_devise_notification Aug 28, 2016

HexterCH changed the title ~~[WIP]Issue #4209 - Add deliver_later option in send_devise_notification~~ [WIP] Issue #4209 - Add deliver_later option in send_devise_notification Aug 28, 2016

add new commenting secion for deliver_later_option and add a small te…

5329b61

…st case for deliver_later_option

HexterCH force-pushed the add-deliver-later-in-send-devise-notification branch from 81e48fd to 5329b61 Compare August 28, 2016 18:40

tegon added Feature Needs more work labels Nov 22, 2017

tegon mentioned this pull request Dec 14, 2017

Allow async mailing via background job #4265

Closed

tegon removed the Needs review label Dec 14, 2017

tegon closed this Jan 12, 2018

seanpdoyle mentioned this pull request Jul 26, 2023

Support deferred Mailer delivery with deliver_later #5610

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] Issue #4209 - Add deliver_later option in send_devise_notification #4224

[WIP] Issue #4209 - Add deliver_later option in send_devise_notification #4224

HexterCH commented Jul 28, 2016 •

edited

Loading

lucasmazza Aug 12, 2016

lucasmazza Sep 4, 2016

HexterCH Sep 8, 2016

lucasmazza commented Aug 12, 2016

lucasmazza Aug 12, 2016

HexterCH commented Aug 17, 2016 •

edited

Loading

HexterCH commented Sep 8, 2016

brunowego commented Jan 31, 2017

tegon commented Nov 25, 2017

tegon commented Jan 12, 2018

seanpdoyle commented Aug 8, 2023

[WIP] Issue #4209 - Add deliver_later option in send_devise_notification #4224

[WIP] Issue #4209 - Add deliver_later option in send_devise_notification #4224

Conversation

HexterCH commented Jul 28, 2016 • edited Loading

lucasmazza Aug 12, 2016

Choose a reason for hiding this comment

lucasmazza Sep 4, 2016

Choose a reason for hiding this comment

HexterCH Sep 8, 2016

Choose a reason for hiding this comment

lucasmazza commented Aug 12, 2016

lucasmazza Aug 12, 2016

Choose a reason for hiding this comment

HexterCH commented Aug 17, 2016 • edited Loading

HexterCH commented Sep 8, 2016

brunowego commented Jan 31, 2017

tegon commented Nov 25, 2017

tegon commented Jan 12, 2018

seanpdoyle commented Aug 8, 2023

HexterCH commented Jul 28, 2016 •

edited

Loading

HexterCH commented Aug 17, 2016 •

edited

Loading