Python Package Refactoring #64
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update setup.py
* Fix LogisticSwaps by updating ExpyXBnoji correctly The reason for doing this is that during the for-loop between lines 94-110, the update of 'ExpyXBnoji' always lags behind the update of 'Binew' by 1 step. Therefore, the final 'ExpyXBnoji' corresponds to the value at t-1 step, not the t step. However, Binew has been updated by t steps. This code fix should also work in the case that ObjTemp < Fmin and the algorithm skips over the for-loop between lines 94-100. * Add citation to new L0Learn paper * Update ChangeLog * Update version to 2.0.5 * Update README.md * Switch travis to osx * Use carma bindings instead of cython * Refactored repos to match! * First attempt at CIBUILDWHEEL * Update wheels.yml * Create appveyor.yml * Update appveyor.yml * build in proper subdirectory * Update appveyor.yml * Try python 37 and not 36 * Bring in submodules! * Update appveyor.yml * Update appveyor.yml * Update appveyor.yml * Update .gitmodules * Update appveyor.yml * simplify CMakeLists * Update testing * Try many environments * set PATH according to cibuildwheel docs * Update appveyor.yml * Move class definitions to headers * Update setup.py * Add python3 library flags * Update setup.py * Update setup.py * Update setup.py * Setting variables for Carma CMakeList * Try with singular values (Ignoring carma build error hint) * Only build Linux atm * Update appveyor.yml * Update Cmake Minimum * Update setup.py * Use CMAKE 3.18 * Update CMakeLists.txt * testing 1 * Try with Forked CARMA * Remove python-dev install for Linux * Update appveyor.yml * Update appveyor.yml * Update appveyor.yml * Update appveyor.yml * Update wheels.yml * Update wheels.yml * Update appveyor.yml * github actions attempt * Update wheels.yml * Update wheels.yml * Use new stable carma release * Flag on LAPACK? * Update CMakeLists.txt * Add direct armadillo submodule * Github Actions CIBUILDWHEEL * Update wheels.yml * try with scikit-build * use -fpic * Update CMakeLists.txt * attempt N * Use "cmake_source_dir" flag * Making progress * Attempt K * Install armadillo beforehand! * Update wheels.yml * Use yum install * Try on just macOS * Working locally! * Update wheels.yml * Update wheels.yml * Update wheels.yml * Update wheels.yml * Update wheels.yml * Update wheels.yml * Update wheels.yml * Update wheels.yml * back to armadillo subdirectory * Update wheels.yml * Update wheels.yml * Attempt J * Try on Ubuntu * Update setup.py * Update wheels.yml * Bump Carma version to 0.6.5 * Update setup.py * Try windows * Update CMakeLists.txt * Update wheels.yml * Skip windows 32 bit builds * Update wheels.yml * Update wheels.yml * Update setup.py * Link armadillo * Update wheels.yml * Based on 'carma_py_example' * Include directories * Update to stable release of carma * Install hypothesis * Remove sparse test first * No 32 bit builds * For Mac and Linux * Update packaging info * Do not support python 3.6 * Upload to PyPi Text Index * Set long_description_content_type * Update wheels.yml * Update wheels.yml * Update wheels.yml * Fix directory name on upload * Update classifiers * Update classifiers again * Hopefully last time updating classifiers * New sparse bindings * Delete args_check Co-authored-by: Jiachang Liu <[email protected]> Co-authored-by: Hussein Hazimeh <[email protected]>
This reverts commit 3b80e05.
|
Hi @hazimehh, Can we set up some time to review this PR? |
* Fix indent * Add tests --------- Co-authored-by: Tim Nonet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things to note: