-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure RHEL tests use a valid version of Management Center [DI-422] #880
base: master
Are you sure you want to change the base?
Conversation
The RHEL publish tests the build by connecting an Management Center instance to it. In #847 this was changed to use a _matching_ version of Hazelcast & Management Center - which isn't correct in all cases (e.g. `5.5.2` Hazelcast & `5.6.0` Management Center) Before this change, it used the latest version of Management Center - derived by inspecting the tags of the (archived) https://github.com/hazelcast/management-center-openshift repo - but the last tag here was `5.3.2` so it wasn't really the latest at all. In [consultation with the Management Center team](https://hazelcast.slack.com/archives/C9S7BV74Z/p1738850975557879), latest is the best option. Changes: - choses latest based on tags - tags are scraped from the `hazelcast/management-center` repo - tags are queried using the `gh` cli tool to avoid checking out the whole repo I don't think we should backport this change, as while it's not correct in earlier versions, it doesn't cause an issues. Fixes: [DI-422](https://hazelcast.atlassian.net/browse/DI-422)
Just had a thought about sorting. Might not work with double digits e.g. |
The tags are returned in date order. I've taken the sort out to avoid adding any extra logic there. |
Actually changed my mind - if we do a patch release of (say) |
Sorry where in the regex I guess we can limit to major/minor but not sure why we should not consider PATCH. Any good reason? |
It's not checking for 0 - that was just an example of the kind of scenario where it could've gone wrong. I was trusting GitHub returning the most recent tag would be the latest version - but when we say |
The RHEL publish tests the build by connecting an Management Center instance to it.
In #847 this was changed to use a matching version of Hazelcast & Management Center - which isn't correct in all cases (e.g.
5.5.2
Hazelcast &5.6.0
Management Center)Before this change, it used the latest version of Management Center - derived by inspecting the tags of the (archived) https://github.com/hazelcast/management-center-openshift repo - but the last tag here was
5.3.2
so it wasn't really the latest at all.In consultation with the Management Center team, latest is the best option.
Changes:
hazelcast/management-center
repogh
cli tool to avoid checking out the whole repoI don't think we should backport this change, as while it's not correct in earlier versions, it doesn't cause an issues.
Fixes: DI-422