List allowed log levels #30
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
List the log levels, as many folks are used to the ones from Log4j
pavolloffay
reviewed
Feb 21, 2017
| | HAWKULAR_APM_PASSWORD | The password to use with the REST client when communicating with the APM server. The default defined in the _setenv.sh_ script is *_password_*. | ||
| | HAWKULAR_APM_CONFIG_REFRESH | Optional business transaction configuration refresh interval (in seconds). | ||
| | HAWKULAR_APM_LOG_LEVEL | The logging level to use when reporting client collector information to the console (uses Java Util Logging levels. The default is _INFO_. | ||
| | HAWKULAR_APM_LOG_LEVEL | The logging level to use when reporting client collector information to the console (uses Java Util Logging levels. The default is _INFO_. Allowed values are FINEST, FINER, FINE, INFO, WARNING and SEVERE. |
Member
There was a problem hiding this comment.
LGTM,
minor comment: maybe use the same styling? In the previous sentence it is in italics..
Just for curiosity. Did you looked/used setenv.sh ? There is a a partial list of all values
Contributor
There was a problem hiding this comment.
+1 - if you could change to italics that would be great. Otherwise LGTM.
There was a problem hiding this comment.
Actually we should standardize the formatting for the entire table while we're at it. The parameters and variables are formatted differently in every row.
Could we make all the parameters and variables in the table bold monospace?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List the log levels, as many folks are used to the ones from Log4j