fix(options): fix colorMap validation

hatemhosny · Sep 7, 2024 · ae94970 · ae94970
1 parent 4da9523
commit ae94970
Show file tree

Hide file tree

Showing 3 changed files with 29 additions and 2 deletions.
diff --git a/src/lib/options/__tests__/validate-options.spec.ts b/src/lib/options/__tests__/validate-options.spec.ts
@@ -206,3 +206,28 @@ test('Tests to validate valueDecimals option', () => {
   const invalidOpts = validateOptions(options);
   expect(invalidOpts.valueDecimals).toBeUndefined();
 });
+
+test('Tests to validate colorMap option', () => {
+  // Valid options
+  const options: any = { colorMap: ['blue', 'red'] };
+  const validatedOpts = validateOptions(options);
+  expect(validatedOpts.colorMap).toStrictEqual(['blue', 'red']);
+
+  // Valid options
+  const options2: any = {
+    colorMap: {
+      India: 'orange',
+      'United States': 'blue',
+    },
+  };
+  const validatedOpts2 = validateOptions(options2);
+  expect(validatedOpts2.colorMap).toStrictEqual({
+    India: 'orange',
+    'United States': 'blue',
+  });
+
+  // Invalid options
+  options.colorMap = 'invalid';
+  const invalidOpts = validateOptions(options);
+  expect(invalidOpts.colorMap).toBeUndefined();
+});
diff --git a/src/lib/options/validate-options.ts b/src/lib/options/validate-options.ts
@@ -134,7 +134,9 @@ export function validateOptions(options: Partial<Options>): Partial<Options> {
     newOptions.dataTransform = options.dataTransform;
   }
 
-  validateColorMap(options.colorMap);
+  if (validateColorMap(options.colorMap)) {
+    newOptions.colorMap = options.colorMap;
+  }
 
   return newOptions;
 }

diff --git a/website/docs/gallery/_gallery-demos.ts b/website/docs/gallery/_gallery-demos.ts
@@ -329,7 +329,7 @@ export const labelsPosition: ChartProps = {
 };
 
 export const labelsPositionNone: ChartProps = {
-  label: 'Labels Position',
+  label: 'Hidden Labels',
   dataUrl: '/data/population.csv',
   dataTransform: (data) =>
     data.map((d) => ({