[WIP] OpenTelemetry First Pass #242
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrkaye97
commented
Nov 2, 2024
mrkaye97
commented
Nov 2, 2024
mrkaye97
commented
Nov 2, 2024
hatchet_sdk/loader.py
Outdated
Comment on lines
151
to
158
| try: | ||
| otel_exporter_oltp_headers = json.loads(_oltp_headers) if isinstance(_oltp_headers, str) else _oltp_headers | ||
| except json.JSONDecodeError: | ||
| otel_exporter_oltp_headers = None |
There was a problem hiding this comment.
this is a hack - I'm sure there's a nicer way to do this (basically need to get the headers in some structured format and parse them to a dict)
mrkaye97
commented
Nov 2, 2024
| from typing import Any | ||
|
|
||
|
|
||
| def flatten(xs: dict[str, Any], parent_key: str, separator: str) -> dict[str, Any]: |
There was a problem hiding this comment.
Python annoyance: In general I try to avoid using Any, but type hinting for arbitrarily nested dictionaries is really clunky AFAIK
9 tasks
mrkaye97
commented
Nov 6, 2024
| action_func = self.action_registry.get(action_name) | ||
| async def handle_start_step_run(self, action: Action): | ||
| with self.otel_tracer.start_as_current_span( | ||
| "hatchet.worker.runner.runner.Runner.handle_start_step_run" |
There was a problem hiding this comment.
would love input on naming here!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better to review without whitespace
Important: There are likely some breaking changes in here (especially with Pydantic), so I'd need to do a fair amount more validation before being willing to merge