Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re CLC issue 292 Avoid using partial init and last #263

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mpilgrem
Copy link

@mpilgrem mpilgrem commented Nov 9, 2024

The motivation for this pull request is:

At some point, GHC versions may warn that init and last are partial, giving advice about alternatives (including unsnoc). This pull request seeks to anticipate that, by avoiding the use of partial functions at the two places where the time package uses init and/or last.

@mpilgrem mpilgrem marked this pull request as draft November 11, 2024 09:48
@mpilgrem
Copy link
Author

I have converted the pull request to draft because it has been suggested that, compared to other approaches, unsnoc has performance issues. I am looking into that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant