Add -Wunused-packages to common warnings #4053
Conversation
| @@ -42,18 +42,13 @@ common defaults | |||
| common test-defaults | |||
| ghc-options: -threaded -rtsopts -with-rtsopts=-N | |||
|
|
|||
| common common-deps | |||
There was a problem hiding this comment.
Deleting this for now as it's contributing more to unused-packages warnings than it's saving duplication..
Will reintroduce this later where it makes sense.
There was a problem hiding this comment.
tbh it seems of questionable utility to me anyway
There was a problem hiding this comment.
mostly a workaround for not yet having haskell/cabal#9569
jhrcek
force-pushed
the
jhrcek/add-Wunused-packages-to-common-warnings
branch
from
a52b7ba to
012d32e
Compare
| ] | ||
| -- not supported in ghc92 |
There was a problem hiding this comment.
CC @soulomoon I used this value-level CPP-less way to ensure this test only runs with GHC 9.4 and newer.
Did this to be able to get rid of "unused ghc dependency" warning.
While I was at it I fixed all the other warnings in this module.
jhrcek
force-pushed
the
jhrcek/add-Wunused-packages-to-common-warnings
branch
from
737728f to
5224a19
Compare
| @@ -283,13 +280,6 @@ executable ghcide | |||
| if !flag(executable) | |||
| buildable: False | |||
|
|
|||
| if flag(ekg) | |||
There was a problem hiding this comment.
ekg dep is only direct dep of ghcide library, not of the executable.
jhrcek
force-pushed
the
jhrcek/add-Wunused-packages-to-common-warnings
branch
from
c9f126d to
47a9dcd
Compare
|
Ready for review. I'm quite happy about the resulting cleanup 🤗 |
|
Looks like a genuine failure, @soulomoon introducing some new warnings for you ;) |
|
These look more like flaky tests to me. The unused-packages above the failure shouldn't fail the build per-se 🤔 |
jhrcek
force-pushed
the
jhrcek/add-Wunused-packages-to-common-warnings
branch
from
261f00e to
9359811
Compare
|
oops, sorry man, I might not have opportunities next time with this pr merged .😂 |
|
No problem, enjoy while you can. Just the usual birth pains of trying to enforce stricter checks 😄 |
No description provided.