-
-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare 1.4.0 #2182
Prepare 1.4.0 #2182
Conversation
jneira
commented
Sep 10, 2021
•
edited
Loading
edited
- Added instructions about the automated hackage release
- Initial list of prs in the changelog
- Make progress towards September monthly release (1.4.0) with ghc-8.10.6 and 8.10.7 support #2176
89a508c
to
53b240a
Compare
@isovector feel free to extend the release description with more details about wingman changes (same for others participants and maintainers of course 🙂 ) |
This still needs version bumps |
Done, all minor revisiones, although technically ghcide should be a major one as a public definition was removed. |
/rerun-workflow Testing |
Will label it for merge tomorrow if nobody disagree |
/rerun-workflow Testing |
i am happy to write wingman release notes tomorrow morning if it's not too late |
@isovector |
35546bb
to
c5ffbc9
Compare
c5ffbc9
to
ce6767e
Compare
If you dont mind i am gonna label as ready to merge, we can add modifications in new prs (or even update the release if it is done) |
ChangeLog.md
Outdated
- We have a *new brand plugin to let you rename indentifiers* thanks to @OliverMadine's great work | ||
![rename-demo](https://user-images.githubusercontent.com/30090176/133071923-b3d91b2a-619f-4151-ab76-ca50442e5ab4.gif) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The plugin is disabled in Cabal so it won't be possible to enable it for binary users. This needs to be highlighted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, didnt notice that 😟
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So i think it is better to remove it from the description directly, as advanced users enabling it on purpose already are aware
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed and opened #2193
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pepeiborra are you fine with the removal?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I respect @OliverMadine choice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems reasonable to me to remove it until we have the multi-component support.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok so it only needs a stamp to go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pepeiborra does it needs some other change?
/rerun-workflow Testing |
* [Call hierarchy] Update change log for 1.0.1.0 * Add hackage release instructions * Add missing new line * Add initial list of merged prs * Update list of prs * Add a initial release description * Add rename plugin * Add rename demo and last pr * Restore significant whitespaces * Correct grammar * Add some newlines * Bump up versions * Complete Changelog * Ignoring time resolution test * Remove reference to rename plugin Co-authored-by: Lei Zhu <[email protected]>