Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare 1.4.0 #2182

Merged
merged 16 commits into from
Sep 15, 2021
Merged

Prepare 1.4.0 #2182

merged 16 commits into from
Sep 15, 2021

Conversation

jneira
Copy link
Member

@jneira jneira commented Sep 10, 2021

ChangeLog.md Show resolved Hide resolved
ChangeLog.md Show resolved Hide resolved
@jneira jneira marked this pull request as ready for review September 13, 2021 11:13
@jneira
Copy link
Member Author

jneira commented Sep 13, 2021

@isovector feel free to extend the release description with more details about wingman changes

(same for others participants and maintainers of course 🙂 )

@jneira
Copy link
Member Author

jneira commented Sep 13, 2021

This still needs version bumps

@jneira
Copy link
Member Author

jneira commented Sep 13, 2021

This still needs version bumps

Done, all minor revisiones, although technically ghcide should be a major one as a public definition was removed.
All but wingman, lot of changes to verify so i bump up to 1.4.0 (//cc @isovector)

@jneira
Copy link
Member Author

jneira commented Sep 13, 2021

/rerun-workflow Testing

@jneira
Copy link
Member Author

jneira commented Sep 13, 2021

Will label it for merge tomorrow if nobody disagree

ChangeLog.md Outdated Show resolved Hide resolved
@jneira
Copy link
Member Author

jneira commented Sep 14, 2021

/rerun-workflow Testing

@isovector
Copy link
Collaborator

isovector commented Sep 14, 2021

i am happy to write wingman release notes tomorrow morning if it's not too late

@jneira
Copy link
Member Author

jneira commented Sep 14, 2021

i am happy to write wingman release notes tomorrow morning if it's not too late

@isovector
I've just write down a dedicated section with the highlights, feel free to edit or replace it

@jneira
Copy link
Member Author

jneira commented Sep 14, 2021

i am happy to write wingman release notes tomorrow morning if it's not too late

If you dont mind i am gonna label as ready to merge, we can add modifications in new prs (or even update the release if it is done)

@jneira jneira added the merge me Label to trigger pull request merge label Sep 14, 2021
ChangeLog.md Outdated
Comment on lines 9 to 10
- We have a *new brand plugin to let you rename indentifiers* thanks to @OliverMadine's great work
![rename-demo](https://user-images.githubusercontent.com/30090176/133071923-b3d91b2a-619f-4151-ab76-ca50442e5ab4.gif)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The plugin is disabled in Cabal so it won't be possible to enable it for binary users. This needs to be highlighted

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, didnt notice that 😟

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So i think it is better to remove it from the description directly, as advanced users enabling it on purpose already are aware

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed and opened #2193

Copy link
Member Author

@jneira jneira Sep 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pepeiborra are you fine with the removal?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I respect @OliverMadine choice

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems reasonable to me to remove it until we have the multi-component support.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok so it only needs a stamp to go ☺️

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pepeiborra does it needs some other change?

@jneira
Copy link
Member Author

jneira commented Sep 14, 2021

/rerun-workflow Testing

@mergify mergify bot merged commit 2535478 into haskell:master Sep 15, 2021
cdsmith pushed a commit to cdsmith/haskell-language-server that referenced this pull request Sep 21, 2021
* [Call hierarchy] Update change log for 1.0.1.0

* Add hackage release instructions

* Add missing new line

* Add initial list of merged prs

* Update list of prs

* Add a initial release description

* Add rename plugin

* Add rename demo and last pr

* Restore significant whitespaces

* Correct grammar

* Add some newlines

* Bump up versions

* Complete Changelog

* Ignoring time resolution test

* Remove reference to rename plugin

Co-authored-by: Lei Zhu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Label to trigger pull request merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants