Do not print "up to date" unless running build #8569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulysses4ever
approved these changes
Nov 3, 2022
|
@mergify refresh |
✅ Pull request refreshed |
|
@mergify requeue |
❌ This pull request head commit has not been previously disembarked from queue. |
|
@cbclemmer just a heads-up: normally you don't need to do anything explicit with Mergify. Just put the label merge-me (or squash+merge) when you think it's ready. What currently blocks this PR is a missing second reviewer. |
|
@ulysses4ever There was some kind of build error with the CI, I was just trying to get it to run again. |
|
All tests are passing |
cbclemmer
added
squash+merge me
mergify
bot
added
the
merge delay passed
alexbiehl
pushed a commit
to alexbiehl/cabal
that referenced
this pull request
Dec 15, 2022
* do not print "up to date" unless running build * Update cabal-tests * Add changelog * Remove accidentally added test generated files Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #4994
"Up to date" will not print unless the
buildcommand is run.I expect this to break tests that use the
buildandruncommands so I'll update them based on the CI results. This should in effect test the PR itself to keep it from regressing.Please include the following checklist in your PR:
Please also shortly describe how you tested your change. Bonus points for added tests!