Bump Cabal version to 3.7 for development #7571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phadej
reviewed
Aug 23, 2021
.github/workflows/windows.yml
Outdated
| @@ -111,4 +111,4 @@ jobs: | |||
| cabal v2-run cabal-install:unit-tests -- --pattern "! (/FileMonitor/ || /VCS/ || /Get/)" | |||
| - name: cabal-tests | |||
| # Using only one job, -j1, to fail less. | |||
| run: cabal v2-run cabal-testsuite:cabal-tests -- -j1 --with-cabal=dist-newstyle\build\x86_64-windows\ghc-8.10.4\cabal-install-3.6.0.0\x\cabal\build\cabal\cabal.exe | |||
| run: cabal v2-run cabal-testsuite:cabal-tests -- -j1 --with-cabal=$(cabal list-bin exe:cabal) | |||
There was a problem hiding this comment.
The windows executor is powershell, so bourne shell stuff doesn't work.
There was a problem hiding this comment.
Yeah, just noticed. Tried something for powershell, if that still doesn't work I'll just resort to not improving this.
There was a problem hiding this comment.
Please make improvements in separate commits. It would be great to have "this is how you bump version" commits, which don't do anything else.
fendor
force-pushed
the
bump-cabal-version-3.7
branch
3 times, most recently
from
57085bb to
a47d2b4
Compare
|
The last remaining CI error seems to stem from some hardwired paths. |
fendor
force-pushed
the
bump-cabal-version-3.7
branch
from
a47d2b4 to
27a7228
Compare
|
Ping, I would appreciate the merge :) |
emilypi
approved these changes
Aug 25, 2021
|
@Mergifyio update |
|
Command
|
jneira
approved these changes
Aug 25, 2021
andreasabel
added
the
re: version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #7569
Please also shortly describe how you tested your change. Bonus points for added tests!
The changes have been created by manually looking for
version:(\s*)3.6.0.0, replacing them withversion:$13.7.0.0, then grepping every occurrence of3.6.0.0in cabal files with3.7.0.0. Thenmake bootstrap-plans-linux bootstrap-jsons-linux, followed by updating the zinza template and thenmake github-actions.