-
Notifications
You must be signed in to change notification settings - Fork 722
Fix the OS string encoding for GNU/Hurd #11401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Mhhhh, I think this modifies behaviour (e.g. creating different folders). |
More precisely, it fixes the behavior. The folders were |
|
A fix is a change of behaviour. So, it needs a different PR template which, at least, includes a changelog entry. |
Following https://github.com/haskell/cabal/pull/9434/files , and as seen in the various gnu_HOST_OS usages in the ghc source code, it is expected that GNU/Hurd is advertised as "gnu", like the autotools do.
The broken behaviour could not have been seen by users since ghc would just not compile. Anyway, I have updated so. |
ffaf1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks!
Co-authored-by: ffaf1 <[email protected]>
Following https://github.com/haskell/cabal/pull/9434/files , and as seen in the various gnu_HOST_OS usages in the ghc source code, it is expected that GNU/Hurd is advertised as "gnu", like the autotools do.
Template Α: This PR modifies behaviour or interface
Include the following checklist in your PR:
significance: significantin the changelog file.