Skip to content

Conversation

@sthibaul
Copy link
Collaborator

@sthibaul sthibaul commented Jan 10, 2026

Following https://github.com/haskell/cabal/pull/9434/files , and as seen in the various gnu_HOST_OS usages in the ghc source code, it is expected that GNU/Hurd is advertised as "gnu", like the autotools do.

Template Α: This PR modifies behaviour or interface

Include the following checklist in your PR:

@ffaf1
Copy link
Collaborator

ffaf1 commented Jan 10, 2026

Mhhhh, I think this modifies behaviour (e.g. creating different folders).

@sthibaul
Copy link
Collaborator Author

sthibaul commented Jan 10, 2026

Mhhhh, I think this modifies behaviour (e.g. creating different folders).

More precisely, it fixes the behavior. The folders were gnu previously. It's the way OS strings are converted that changed at some point and ended up using hurd instead of gnu, breaking the package build. (i.e. it was never actually built with the changed directory)

@ulysses4ever
Copy link
Collaborator

A fix is a change of behaviour. So, it needs a different PR template which, at least, includes a changelog entry.

Following https://github.com/haskell/cabal/pull/9434/files , and as seen
in the various gnu_HOST_OS usages in the ghc source code, it is expected that
GNU/Hurd is advertised as "gnu", like the autotools do.
@sthibaul
Copy link
Collaborator Author

A fix is a change of behaviour. So, it needs a different PR template which, at least, includes a changelog entry.

The broken behaviour could not have been seen by users since ghc would just not compile.

Anyway, I have updated so.

Copy link
Collaborator

@ffaf1 ffaf1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants