Add js-options field to cabal file to allow passing custom preprocessing options for js (#10721) #10722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing options for js (haskell#10721)
|
Please let me know if this is an acceptable feature at all, if so I'm gonna add any needed doc changes / changelogs. |
Swordlash
changed the title
mpickering
reviewed
Jan 7, 2025
| @@ -621,6 +621,7 @@ buildInfoFieldGrammar = | |||
| <*> monoidalFieldAla "cc-options" (alaList' NoCommaFSep Token') L.ccOptions | |||
| <*> monoidalFieldAla "cxx-options" (alaList' NoCommaFSep Token') L.cxxOptions | |||
| ^^^ availableSince CabalSpecV2_2 [] | |||
| <*> monoidalFieldAla "js-options" (alaList' NoCommaFSep Token') L.jsOptions | |||
There was a problem hiding this comment.
See above, needs to be guarded by availableSince.
There was a problem hiding this comment.
I thought about it but got confused by a fact js-sources are not guarded. Is it an omission?
Which value should I put here?
There was a problem hiding this comment.
@mpickering ? Should I add version 3.16?
|
Can you please add some tests?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR fixes the issue (#10721) by adding a new
js-optionsfield to cabal file that are passed tocomponentJsGhcOptions.Please advise on the testing strategy, if any.
Thank you @hsyl20 for investigation and suggestion how to fix it.