Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ppHsc2hs: treat Right [] as not broken #10707

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

poscat0x04
Copy link
Contributor

@poscat0x04 poscat0x04 commented Jan 4, 2025

Hopefully fixes #10702.


Template Α: This PR modifies behaviour or interface

Include the following checklist in your PR:

@ulysses4ever ulysses4ever added the re: preprocessors Concerning preprocessors such as alex and happy label Jan 4, 2025
@ulysses4ever ulysses4ever linked an issue Jan 4, 2025 that may be closed by this pull request
@ulysses4ever
Copy link
Collaborator

CI is green, which is good. Let's see if we can get the required two reviews...

@ulysses4ever
Copy link
Collaborator

@gbaz you have some experience with the preprocessor code. Could you maybe take a look and approve if this change makes sense?

@mpickering
Copy link
Collaborator

I don't think this is a correct fix.

Note that dependencyClosure says that it returns Right [] if one of the given package ids doesn't appear in the index. Therefore you have a broken situation where you have a dependency on a package which doesn't appear in the package database. It seems like the question to answer is, what is the package id which fails to be found in the installed package index, and why does is it not there?

@ulysses4ever
Copy link
Collaborator

@mpickering thank you for chiming in.

@poscat0x04 I guess we won't proceed with this idea. We should get back to the drawing board.

@poscat0x04 is that true that #10702 only concerns the Hooks build type? In that case, the person to ask about it is @sheaf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
attention: needs-review re: preprocessors Concerning preprocessors such as alex and happy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cabal repl fails with ppHsc2hs: broken closure: []
3 participants