Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Cabal library and cabal-install version to 3.7 #7569

Closed
fendor opened this issue Aug 23, 2021 · 8 comments · Fixed by #7571 or #7683
Closed

Bump Cabal library and cabal-install version to 3.7 #7569

fendor opened this issue Aug 23, 2021 · 8 comments · Fixed by #7571 or #7683
Assignees
Labels
attention: pr-welcome re: version About the version of the Cabal library and cabal-install

Comments

@fendor
Copy link
Collaborator

fendor commented Aug 23, 2021

Development version should not be equal to release version.

This is blocking development on #7489, as the flag --enable-build-info is guarded s.t. that it can not be accidentally used with older Cabal versions.

@Mikolaj
Copy link
Member

Mikolaj commented Aug 23, 2021

@emilypi: am I right we can do that fine already?

@emilypi
Copy link
Member

emilypi commented Aug 23, 2021

@Mikolaj yeah we're good.

@andreasabel
Copy link
Member

Not sure why, but cabal-install is still thinking it is 3.6:

$ cabal --numeric-version
3.6

$ cabal --version
cabal-install version 3.6
compiled using version 3.7.0.0 of the Cabal library 

One half of the job seems to be missing still, or am I misunderstanding something?
Having both the released 3.6 and the master claiming they are 3.6 confuses me...

@andreasabel andreasabel reopened this Sep 23, 2021
@jneira
Copy link
Member

jneira commented Sep 23, 2021

I think this issue is about Cabal the library and no cabal-install, note the
compiled using version 3.7.0.0 of the Cabal library
so this could be closed opening a new one specific to cabal-install (or add cabal-install in the description of this)

@jneira jneira changed the title Bump Cabal version to 3.7 Bump Cabal (the library) version to 3.7 Sep 23, 2021
@emilypi
Copy link
Member

emilypi commented Sep 23, 2021

There's a value in Distribution/Client/Utils.hs with the cabalInstallVersion you need to bump

cabalInstallVersion = mkVersion [3,6]

This is to do away with the paths module whose sole purpose was to do this, and it screwed up our ability to produce coverage. Right now, I think it deserves its own dedicated module. Just haven't had time.

@andreasabel andreasabel self-assigned this Sep 23, 2021
@andreasabel andreasabel added the re: version About the version of the Cabal library and cabal-install label Sep 23, 2021
@andreasabel
Copy link
Member

@jneira:

I think this issue is about Cabal the library and no cabal-install,

Ah, I wasn't aware that "Cabal" (capital) refers to strictly the library only. I was going to report a new issue but then found this one and it matched in my mind.

@emilypi:

There's a value in Distribution/Client/Utils.hs with the cabalInstallVersion you need to bump

Thanks for the pointer, I give it a try.

andreasabel added a commit to andreasabel/cabal that referenced this issue Sep 23, 2021
Move `cabalInstallVersion` to its own module
`Distribution.Client.Version` as suggested by @emilypi at
haskell#7569 (comment).
andreasabel added a commit to andreasabel/cabal that referenced this issue Sep 23, 2021
@emilypi
Copy link
Member

emilypi commented Sep 23, 2021

Thanks @andreasabel - I think as long as this sits in its own dedicated namespace so it doesn't get lost and we make sure it's on the release checklists, this should be sufficient.

@andreasabel
Copy link
Member

PR at #7683.

@jneira jneira changed the title Bump Cabal (the library) version to 3.7 Bump Cabal library and cabal-install version to 3.7 Sep 24, 2021
jneira pushed a commit to andreasabel/cabal that referenced this issue Sep 27, 2021
Move `cabalInstallVersion` to its own module
`Distribution.Client.Version` as suggested by @emilypi at
haskell#7569 (comment).
jneira pushed a commit to andreasabel/cabal that referenced this issue Sep 27, 2021
@mergify mergify bot closed this as completed in #7683 Sep 27, 2021
mergify bot added a commit that referenced this issue Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
attention: pr-welcome re: version About the version of the Cabal library and cabal-install
Projects
None yet
5 participants