Use only fixed-width uints in the C itoa functions #702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing logic for decimal encoding of signed ints was a bit more complicated than necessary in its handling for negative numbers, mostly because of negation overflowing for INT_MIN. But the absolute value of the smallest signed Int16 does fit into an unsigned Word16 without overflowing, allowing some simplification. Additionally, on hardware with slow integer division instructions, fast division-by-known-divisor is typically faster for unsigned types, so this change may lead to a slight speed-up on such platforms. (We could almost certainly produce slightly better code still for these platforms by hand, for example by exploiting the fact that after the first division the numbers are small enough that a quotient by ten can be extracted with a single mulhi and no shift.)
If the absolute value of the input is small enough to enter this branch, then it fits in an Int and takes the very first branch instead.
Bodigrim
approved these changes
Jan 1, 2025
|
Cool! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit messages.