Theme: no copy bar #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The copy button is still there; it now overlaps the right-top corner of the code. This is only a problem if the first line of the code block is longer than the screen is wide, but: 1. This is not super common; 2. It's still mostly readable; 3. We're not the only ones with this unfortunate css; 4. I have no idea how to do it better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on top of #2; only the last 1 commit is new.
This removes the grey (if a syntax highlighting language is set) or mostly empty (if not) bar on top of a code block; the highlighting language name is removed with it. (This name was made visible in #2 by fixing the code block theme.)
However, the copy button is still there: it's still in the right-top corner of the code block, and thus overlaps a small part of the first line of a code block. This is typically not really a problem, but any suggestions for how to improve that are welcome.