Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update-versions: update librdkafka to latest + niv update + ghc 8107 #191

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Gau-thier
Copy link
Contributor

@Gau-thier Gau-thier commented Jan 7, 2022

Because of an issue with docker on my local environment, I am not able to fully run the tests.
Can you check on your side @AlexeyRaga?

Closes #182

pkgs = (import ./nix/nixpkgs.nix {
inherit compiler;
});
pkgs = (import ./nix/nixpkgs.nix { inherit compiler; });
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added nixfmt in shell.nix to format all the nix files.

environment:
SERVICE_NAME: zookeeper
ZOOKEEPER_CLIENT_PORT: 2181
version: '3.8'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to make this docker-compose compliant

# "openssl-1.0.2u"
# ];
# }
config.permittedInsecurePackages = [ "openssl-1.0.2u" ];
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the line required by nettools I guess I should add a comment, what do you think?

"url_template": "https://github.com/<owner>/<repo>/archive/<rev>.tar.gz"
},
"nixpkgs": {
"branch": "nixos-21.05",
"branch": "nixpkgs-unstable",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my point of view, I prefer to go on unstable to get latest dependencies and don't wait for months before being able to get the latest release.
I can switch back to nixos if you want.

@@ -8,6 +8,9 @@ pkgs.mkShell {
nettools
niv
gmp
docker-compose
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you provide a docker-compose.yaml it is good to also provider docker-compose binary.

@@ -8,6 +8,9 @@ pkgs.mkShell {
nettools
niv
gmp
docker-compose
nixfmt
colima
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a way to use docker on MacOS without having to install Docker Desktop which is not free anymore in some cases.

@AlexeyRaga
Copy link
Member

Actually, I don't use Nix build and don't want to maintain it.
I am thinking of dropping it in favour of a simple shell.nix that adds librdkafka.
This stuff is getting more and more complicated, which I don't think is necessary.

@Gau-thier
Copy link
Contributor Author

Actually, I don't use Nix build and don't want to maintain it.

Totally understood and agreed that 😉

I am thinking of dropping it in favour of a simple shell.nix that adds librdkafka.
This stuff is getting more and more complicated, which I don't think is necessary.

In the current state, this is already what you provide: a "simple" nix-shell. I switched to the unstable branch, to avoid a 6 months delay between "new version is available on unstable and new version will be available in next release".
And niv allow you to run niv update without doing any action (files sources.nix and sources.json are generated and managed by niv you don't have to do anything).

From my point of view, if you add a nix-shell you better provide all the necessary binaries (stack, docker, docker-compose, niv, librdkafka) in order to ease contributing. How confortable it is to simply run cd hw-kafka-client and know you are ready to contribute?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update librdkafka version
2 participants