-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update-versions: update librdkafka to latest + niv update + ghc 8107 #191
base: main
Are you sure you want to change the base?
Conversation
pkgs = (import ./nix/nixpkgs.nix { | ||
inherit compiler; | ||
}); | ||
pkgs = (import ./nix/nixpkgs.nix { inherit compiler; }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added nixfmt
in shell.nix to format all the nix files.
environment: | ||
SERVICE_NAME: zookeeper | ||
ZOOKEEPER_CLIENT_PORT: 2181 | ||
version: '3.8' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to make this docker-compose compliant
# "openssl-1.0.2u" | ||
# ]; | ||
# } | ||
config.permittedInsecurePackages = [ "openssl-1.0.2u" ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the line required by nettools
I guess I should add a comment, what do you think?
"url_template": "https://github.com/<owner>/<repo>/archive/<rev>.tar.gz" | ||
}, | ||
"nixpkgs": { | ||
"branch": "nixos-21.05", | ||
"branch": "nixpkgs-unstable", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From my point of view, I prefer to go on unstable
to get latest dependencies and don't wait for months before being able to get the latest release.
I can switch back to nixos if you want.
@@ -8,6 +8,9 @@ pkgs.mkShell { | |||
nettools | |||
niv | |||
gmp | |||
docker-compose |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you provide a docker-compose.yaml
it is good to also provider docker-compose
binary.
@@ -8,6 +8,9 @@ pkgs.mkShell { | |||
nettools | |||
niv | |||
gmp | |||
docker-compose | |||
nixfmt | |||
colima |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a way to use docker
on MacOS without having to install Docker Desktop which is not free anymore in some cases.
Actually, I don't use Nix build and don't want to maintain it. |
Totally understood and agreed that 😉
In the current state, this is already what you provide: a "simple" From my point of view, if you add a |
Because of an issue with docker on my local environment, I am not able to fully run the tests.
Can you check on your side @AlexeyRaga?
Closes #182