BasicAuth: Allow disabling sending WWW-Authenticate header #1387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi agrafix, Thanks for your contribution. The CI has been fixed, could you rebase your branch to see if it passes the CI checks? |
agrafix
force-pushed
the
agrafix/auth-prompt
branch
from
e751df4 to
4e894d4
Compare
|
@agrafix Hi! Unfortunately we lost CI logs, could you please rebase your branch and push it again? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, the
BasicAuthmodule sends theWWW-Authenticateheader by default viaservant-server. This isn't always desirable, since, when called via AJAX, it causes the browser to surface a login prompt on authentication failure.This PR makes that behavior configurable.