Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proper boolean options; enable-matcher; imply enable-stack #6

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Proper boolean options; enable-matcher; imply enable-stack #6

wants to merge 2 commits into from

Commits on Jan 27, 2024

  1. Proper boolean options; enable-matcher; imply enable-stack 

    The options `enable-stack`, `stack-no-global`, `stack-setup-ghc` and `disable-matcher` are now proper booleans only accepting `true` or `false`.
Previously, they were true when set to some non-empty string, even when set to "false" or "off" etc.

`disable-matcher` is deprecated in favour of a new positive form `enable-matcher`.

`enable-stack` is now implied by setting another stack-related option, i.e., one of `stack-version`, `stack-no-global` and `stack-setup-ghc`.
Previously, it was a prerequisite to these options.

Contradictory options now give an error, such as `stack-no-global` with `ghc-version` or `enable-stack: false` with `stack-version`.

Fixes: haskell/actions#142
    @andreasabel
    andreasabel committed Jan 27, 2024
    Configuration menu
    Copy the full SHA
    dea33d5 View commit details
    Browse the repository at this point in the history

  2. Delete defaults for options ghc/cabal/stack-version and enable-stack

    @andreasabel
    andreasabel committed Jan 27, 2024
    Configuration menu
    Copy the full SHA
    246dc48 View commit details
    Browse the repository at this point in the history