Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

H-2767: Create and allow assigning editor permissions on data types #6399

Conversation

TimDiekmann
Copy link
Member

🌟 What is the purpose of this PR?

Data types needs to be updated eventually.

🔍 What does this change?

Aligns the permissions for data types with the other ontology types

Pre-Merge Checklist 🚀

🚢 Has this modified a publishable library?

This PR:

  • does not modify any publishable blocks or libraries, or modifications do not need publishing

📜 Does this require a change to the docs?

The changes in this PR:

  • are internal and do not require a docs change

🕸️ Does this require a change to the Turbo Graph?

The changes in this PR:

  • do not affect the execution graph

Copy link
Contributor

Benchmark results

@rust/hash-graph-benches – Integrations

scaling_read_entity_complete_zero_depth

Function Value Mean Flame graphs
entity_by_id 25 entities $$3.41 \mathrm{ms} \pm 11.7 \mathrm{μs}\left({\color{red}22.6 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 1 entities $$2.06 \mathrm{ms} \pm 38.8 \mathrm{μs}\left({\color{gray}1.92 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 5 entities $$2.02 \mathrm{ms} \pm 10.3 \mathrm{μs}\left({\color{gray}0.008 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 10 entities $$2.24 \mathrm{ms} \pm 13.8 \mathrm{μs}\left({\color{gray}0.522 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 50 entities $$4.22 \mathrm{ms} \pm 20.5 \mathrm{μs}\left({\color{gray}2.45 \mathrm{\%}}\right) $$ Flame Graph

representative_read_entity

Function Value Mean Flame graphs
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/uk-address/v/1 $$17.0 \mathrm{ms} \pm 193 \mathrm{μs}\left({\color{lightgreen}-27.110 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/song/v/1 $$16.4 \mathrm{ms} \pm 206 \mathrm{μs}\left({\color{lightgreen}-29.664 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/playlist/v/1 $$16.5 \mathrm{ms} \pm 137 \mathrm{μs}\left({\color{gray}-2.547 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/building/v/1 $$16.4 \mathrm{ms} \pm 155 \mathrm{μs}\left({\color{gray}-1.978 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/page/v/2 $$15.4 \mathrm{ms} \pm 174 \mathrm{μs}\left({\color{lightgreen}-6.567 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/block/v/1 $$16.9 \mathrm{ms} \pm 228 \mathrm{μs}\left({\color{red}5.54 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/person/v/1 $$16.9 \mathrm{ms} \pm 205 \mathrm{μs}\left({\color{gray}4.16 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/organization/v/1 $$15.6 \mathrm{ms} \pm 171 \mathrm{μs}\left({\color{gray}-4.021 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/book/v/1 $$16.6 \mathrm{ms} \pm 181 \mathrm{μs}\left({\color{gray}-2.164 \mathrm{\%}}\right) $$ Flame Graph

representative_read_entity_type

Function Value Mean Flame graphs
get_entity_type_by_id Account ID: d4e16033-c281-4cde-aa35-9085bf2e7579 $$2.13 \mathrm{ms} \pm 5.82 \mathrm{μs}\left({\color{gray}0.111 \mathrm{\%}}\right) $$ Flame Graph

representative_read_multiple_entities

Function Value Mean Flame graphs
link_by_source_by_property depths: DT=0, PT=2, ET=2, E=2 $$86.2 \mathrm{ms} \pm 356 \mathrm{μs}\left({\color{gray}-0.819 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=0, PT=0, ET=2, E=2 $$82.9 \mathrm{ms} \pm 352 \mathrm{μs}\left({\color{gray}0.370 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=0, PT=0, ET=0, E=2 $$73.8 \mathrm{ms} \pm 378 \mathrm{μs}\left({\color{gray}-0.340 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=2, PT=2, ET=2, E=2 $$90.1 \mathrm{ms} \pm 370 \mathrm{μs}\left({\color{gray}-1.120 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=255, PT=255, ET=255, E=255 $$99.2 \mathrm{ms} \pm 427 \mathrm{μs}\left({\color{gray}-0.325 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=0, PT=0, ET=0, E=0 $$39.8 \mathrm{ms} \pm 326 \mathrm{μs}\left({\color{gray}4.51 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=0, PT=2, ET=2, E=2 $$53.6 \mathrm{ms} \pm 264 \mathrm{μs}\left({\color{gray}0.563 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=0, PT=0, ET=2, E=2 $$48.6 \mathrm{ms} \pm 270 \mathrm{μs}\left({\color{gray}0.138 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=0, PT=0, ET=0, E=2 $$42.8 \mathrm{ms} \pm 170 \mathrm{μs}\left({\color{gray}-0.455 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=2, PT=2, ET=2, E=2 $$56.3 \mathrm{ms} \pm 305 \mathrm{μs}\left({\color{gray}-1.127 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=255, PT=255, ET=255, E=255 $$66.2 \mathrm{ms} \pm 237 \mathrm{μs}\left({\color{gray}-0.209 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=0, PT=0, ET=0, E=0 $$38.8 \mathrm{ms} \pm 221 \mathrm{μs}\left({\color{gray}-1.319 \mathrm{\%}}\right) $$ Flame Graph

scaling_read_entity_complete_one_depth

Function Value Mean Flame graphs
entity_by_id 25 entities $$180 \mathrm{ms} \pm 709 \mathrm{μs}\left({\color{gray}-0.736 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 1 entities $$20.8 \mathrm{ms} \pm 76.4 \mathrm{μs}\left({\color{gray}0.637 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 5 entities $$27.0 \mathrm{ms} \pm 102 \mathrm{μs}\left({\color{gray}-1.073 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 10 entities $$53.0 \mathrm{ms} \pm 3.00 \mathrm{ms}\left({\color{red}64.8 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 50 entities $$268 \mathrm{ms} \pm 1.81 \mathrm{ms}\left({\color{lightgreen}-95.084 \mathrm{\%}}\right) $$ Flame Graph

scaling_read_entity_linkless

Function Value Mean Flame graphs
entity_by_id 100 entities $$2.24 \mathrm{ms} \pm 8.95 \mathrm{μs}\left({\color{red}7.36 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 1000 entities $$3.01 \mathrm{ms} \pm 17.2 \mathrm{μs}\left({\color{gray}3.14 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 10000 entities $$13.5 \mathrm{ms} \pm 33.4 \mathrm{μs}\left({\color{gray}-0.881 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 1 entities $$1.99 \mathrm{ms} \pm 4.79 \mathrm{μs}\left({\color{gray}0.187 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 10 entities $$2.03 \mathrm{ms} \pm 8.65 \mathrm{μs}\left({\color{gray}0.293 \mathrm{\%}}\right) $$ Flame Graph

@vilkinsons vilkinsons changed the title Create and allow assigning editor permissions on data types H-2767: Create and allow assigning editor permissions on data types Feb 10, 2025
@TimDiekmann TimDiekmann added this pull request to the merge queue Feb 12, 2025
Merged via the queue into main with commit 035b26c Feb 12, 2025
147 checks passed
@TimDiekmann TimDiekmann deleted the t/h-2767-create-if-necessary-and-allow-assigning-editor-permissions branch February 12, 2025 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/apps > hash* Affects HASH (a `hash-*` app) area/apps > hash-api Affects the HASH API (app) area/apps area/libs Relates to first-party libraries/crates/packages (area) area/tests > integration New or updated integration tests area/tests New or updated tests type/eng > backend Owned by the @backend team
Development

Successfully merging this pull request may close these issues.

2 participants