Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

H-3545, H-4032: Update readonly array display in editor, fix scroll behavior in editor slide #6377

Merged
merged 4 commits into from
Feb 7, 2025

Conversation

CiaranMn
Copy link
Member

@CiaranMn CiaranMn commented Feb 7, 2025

🌟 What is the purpose of this PR?

  1. Updates the full display of readonly array values in the entity editor to be the same as in editing mode
  2. Fixes an issue when clicking on a cell in the entity editor in a slide, where you'd end up with two scroll bars (body and slide)
  3. Fixes styling issue with a sort dropdown in the actions queue

See demo.

Pre-Merge Checklist 🚀

🚢 Has this modified a publishable library?

This PR:

  • does not modify any publishable blocks or libraries, or modifications do not need publishing

📜 Does this require a change to the docs?

The changes in this PR:

  • are internal and do not require a docs change

🕸️ Does this require a change to the Turbo Graph?

The changes in this PR:

  • do not affect the execution graph

⚠️ Known issues

There's still an issue when clicking into a cell in the entity editor whereby the slide remains scrollable. Fixing this requires reworking a bit of how we lock scrolling, if it becomes annoying.

❓ How to test this?

  1. Not possible in preview deployment because entities in prod lack metadata which the editor relies on.

📹 Demo

Old behavior

Shows both scroll issue and previous readonly array display

Kapture.2025-02-07.at.12.40.21.mp4

New behavior

Kapture.2025-02-07.at.12.36.29.mp4

Action queue sort

Screenshot 2025-02-07 at 17 01 32

@CiaranMn CiaranMn requested a review from vilkinsons February 7, 2025 12:45
@CiaranMn CiaranMn self-assigned this Feb 7, 2025
@github-actions github-actions bot added area/apps > hash* Affects HASH (a `hash-*` app) type/eng > frontend Owned by the @frontend team area/apps labels Feb 7, 2025
vilkinsons
vilkinsons previously approved these changes Feb 7, 2025
@CiaranMn CiaranMn changed the title H-3545: Update readonly array display in editor, fix scroll behavior in editor slide H-3545, H-4032: Update readonly array display in editor, fix scroll behavior in editor slide Feb 7, 2025
Copy link
Member

@vilkinsons vilkinsons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ty!

@vilkinsons vilkinsons added this pull request to the merge queue Feb 7, 2025
Merged via the queue into main with commit 0ba2f48 Feb 7, 2025
32 checks passed
@vilkinsons vilkinsons deleted the cm/update-readonly-array-display branch February 7, 2025 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/apps > hash* Affects HASH (a `hash-*` app) area/apps type/eng > frontend Owned by the @frontend team
Development

Successfully merging this pull request may close these issues.

2 participants